-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix 1715 drop profiles support for labeled sources #2027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 1715 drop profiles support for labeled sources #2027
Conversation
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
We are removing the support for labeled sources coupled with profile based sources
Currently, when we read some sources by labels, we would get their names. For example: when we search by labels : But, if
This has been talked here @ryanjbaxter this is ready also, and unlike the previous ones, is more substantial. |
| return labelsToSearchAgainst.entrySet().containsAll((labels.entrySet())); | ||
| }).toList(); | ||
|
|
||
| // Compute profile-based source names (based on the ones we found by labels) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the actual fix: we are no longer taking into consideration includeProfileSpecificSources for labeled searches.
Everything else in this PR is changes around this sole piece of code
No description provided.