Skip to content

Conversation

@wind57
Copy link
Contributor

@wind57 wind57 commented Sep 28, 2025

No description provided.

Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
@wind57
Copy link
Contributor Author

wind57 commented Sep 29, 2025

  • what are we doing here?

We are removing the support for labeled sources coupled with profile based sources

  • What is the current way of doing things?

Currently, when we read some sources by labels, we would get their names. For example:

apiVersion: v1
kind: ConfigMap
metadata:
  labels:
    color: red
  name: paint

when we search by labels : color: red, we will find and read this configmap.

But, if includeProfileSpecificSources exists, we would read all other configmaps matching this profile. For example, if active profiles : [dev, k8s], then we would also try to read:

paint-dev
paint-k8s
  • Why is this a problem and we have to drop such support?

This has been talked here

@ryanjbaxter this is ready also, and unlike the previous ones, is more substantial.

return labelsToSearchAgainst.entrySet().containsAll((labels.entrySet()));
}).toList();

// Compute profile-based source names (based on the ones we found by labels)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the actual fix: we are no longer taking into consideration includeProfileSpecificSources for labeled searches.

Everything else in this PR is changes around this sole piece of code

@wind57 wind57 marked this pull request as ready for review September 29, 2025 08:16
@ryanjbaxter ryanjbaxter added this to the 5.0.0-M3 milestone Sep 29, 2025
@ryanjbaxter ryanjbaxter merged commit 9ed11aa into spring-cloud:main Sep 29, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants